feature: Service hours chart #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idreyn
requested review from
mathcolo,
nathan-weinberg,
austinjpaul,
skaplan-dev,
devinmatte and
PatrickCleary
as code owners
github-actions
bot
added
backend
devinmatte
reviewed
Oct 30, 2023
tsconfig.json
Outdated
| @@ -24,6 +24,6 @@ | |||
| } | |||
| ] | |||
| }, | |||
| "include": ["next-env.d.ts", "globals.d.ts", "**/*.ts", "**/*.tsx", ".next/types/**/*.ts"], | |||
| "include": ["next-env.d.ts", "globals.d.ts", "**/*.ts", "**/*.tsx", ".next/types/**/*.ts", "common/components/charts/TimeSeriesChart"], | |||
There was a problem hiding this comment.
Can I ask why? I would expect this would already be covered by "**/*.ts", "**/*.tsx"
There was a problem hiding this comment.
Very strange. I did not make this change manually, some tool might have done it
PatrickCleary
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to graph the total number of (scheduled and delivered) service hours for Red, Orange, and Blue lines. This is a complementary metric to trip counts, which also happens to be more robust to shuttling.
Changes
Adds a new graph to
/<line>/service:For now weekly/monthly aggregation is done on-the-fly instead of using agg tables, so large queries (2+ years) sometimes fail. There's also no reliable data before about 2018.
Also: I'm using
<TimeSeriesChart>for the first time here! It powers this chart and now the scheduled/delivered trips chart, too.Testing Instructions
Visit the Service pages for Red, Orange, Blue and confirm that this graph loads and renders correctly.